Repository navigation
Preserve compound index targets across exception regions - #618
Merged
dadhi merged 2 commits intoNov 10, 2026
Merged
Conversation
dadhi
requested changes
Nov 10, 2026
Compound index assignments currently reject exception-region indices. Keep the target and indices in locals until all index expressions finish, then reload them for the getter and setter. Preserve the existing direct path for indices without exception regions.
Wrap complex-argument membership in an aggressively inlined CompilerContext method. Reuse an aggressively inlined value-or-address local loader in compound assignments and ordinary method calls. Exercise concrete struct values and by-reference receivers with and without exception-region indices, checking mutation and cleanup against System compilation.
jogibear9988
force-pushed
the
fix/compound-index-exceptions-standalone
branch
from
November 10, 2026 14:04
d8afaef to
929ecab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compound index assignments currently reject exception-region indices. Keep the target and indices in locals until all index expressions finish, then reload them for the getter and setter. Preserve the existing direct path for indices without exception regions. Use the aggressively inlined HasComplexArguments context helper for all five complex-argument lookups and EmitLoadLocalVariableOrAddress for the three matching receiver reloads in compound assignments and method calls. These helpers reuse existing metadata and emission without adding compiler-context fields.
Two-index indexers; exception regions in either index; add assignment, pre-increment and post-decrement; getter/setter counts, mutation, side effects and exceptions. Ordinary assignment fallback remains unchanged. Additional regressions cover concrete struct parameters, returned struct values and by-reference struct parameters, with and without exception-region indices; results, mutations and cleanup order are checked against System compilation. Regressions use strict FEC compilation for both Standard and LightExpression.
Validation
Release solution build: zero warnings/errors.
Measurements
Current master
ce28e2b0→ this change, Release, Windows ARM64, .NET 8.0.28 / 10.0.9. Compilation uses prebuilt trees; runtime measures invocation through the same wrapper. Two fresh process rounds with reversed load order, seven samples per round, about 30 ms calibration, one logical CPU and tiered compilation disabled. Tables use the median of the two per-round medians.The controls below produce correct results on master for their measured inputs. Newly supported trees have no valid before/after execution comparison because master rejects them, produces incorrect results or emits invalid IL. Timings include machine and JIT/code-placement variation; the unchanged add control helps show that variation. These observations do not prove universal performance neutrality.
net8.0 results (master → change)
net10.0 results (master → change)
Emitted IL differs in these measured workloads: none.
No measured allocation increase above 0.1 B/op in these controls.