Repository navigation
refactor: move gRPC call plumbing out of DaprClientImpl - #1883
Open
javier-aliaga wants to merge 2 commits into
Open
javier-aliaga wants to merge 2 commits into
javier-aliaga wants to merge 2 commits into
Conversation
Move intercept, createMono, createFlux and the stream observers into a package-private DaprGrpcCalls class. DaprClientImpl calls it instead. No public API change. Part of dapr#1875 Signed-off-by: Javier Aliaga <javier@diagrid.io>
Both became unused when the gRPC helpers moved to DaprGrpcCalls. Part of dapr#1875 Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
marked this pull request as ready for review
October 29, 2026 10:17
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1883 +/- ##
============================================
- Coverage 80.69% 80.64% -0.05%
Complexity 2851 2851
============================================
Files 275 276 +1
Lines 8459 8464 +5
Branches 911 911
============================================
Hits 6826 6826
- Misses 1266 1272 +6
+ Partials 367 366 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cicoyle
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First step of splitting
DaprClientImplinto package-private classes, one per building block. This PR moves the shared gRPC code that every later step needs.DaprGrpcCallsholdsintercept,createMono,createFluxand the two stream observers. The bodies are unchanged.DaprClientImplcallsgrpcCallsinstead of its own private methods.interceptno longer takes the stub, because every caller passedasyncStub.DaprClientImplgoes from 2,771 to 2,684 lines.Issue reference
Part of #1875
Checklist
sdkunit tests (593) cover these paths through the public methods and pass unchanged.