Repository navigation
Require an approved proposal issue before new integration PRs - #748
Open
kacperlukawski wants to merge 1 commit into
Open
kacperlukawski wants to merge 1 commit into
kacperlukawski wants to merge 1 commit into
Conversation
Adds an issue form so contributors can either discuss the need for an integration or propose one that already exists, a PR template that links back to it, and a status check that fails unless the PR body links an issue labeled approved. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@bilgeyucel This is an idea how to change the workflow in that repository, so each contribution starts with an issue. Let's discuss that next week. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/ISSUE_TEMPLATE/new-integration.yml) for proposing a new integration, or just discussing whether one's needed, before a PR is openedCloses #123).github/workflows/require-approved-issue.yml) that fails the PR unless its body links an issue labeledapprovedThis does not restrict who can open a PR — any contributor, org member or not, can still open one. It only gates merging: the check fails until the linked issue is labeled
approved.Enabling enforcement
The workflow runs and reports a status on every PR, but nothing blocks merge until it's marked required. To enable:
maincheckjob from theRequire approved issueworkflowOnce that's set, PRs without a linked
approvedissue can't be merged, though they can still be opened and discussed.Test plan
approved, open a PR withCloses #<that issue>— confirm the check passes🤖 Generated with Claude Code