[gregorydemay]

Adds the scan timer of the automatic deposit flow of #272: every minute, the due watched addresses are read in batches, a balance reaching the minimum deposit amount is queued exactly as deposit_sol would queue it, with the fee in force, and a failed read counts as a scan so that the cost of a registration stays within its schedule. Since deposit_sol and a scan may read the balance of the same address concurrently, a deposit_sol call during whose balance read a scan queued a deposit for the account returns that deposit and charges only the read, so that the same balance is never queued twice. Covered by unit tests of the scan and of that interleaving, and a PocketIC test of a deposit detected and queued by the timer.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

A concurrent manual deposit can race with the scan and trigger the duplicate in-flight deposit assertion.

1 open finding

• Prevent duplicate deposit queueing during scan and deposit interleaving · New

What changed in this PR

Adds timer-driven scanning of watched Solana deposit addresses and queues eligible deposits automatically.

Changes:

• Adds batched balance scanning with scheduling and concurrency guards.
• Adds scan metrics and unit/integration coverage.
• Updates automatic-deposit design documentation.

File	Description
minter/​src/​storage/​mod.rs	Stores scan outcome counters.
minter/​src/​state/​mod.rs	Adds scan task and deposit-call lookup.
minter/​src/​rpc/​mod.rs	Enables the balance batching helper.
minter/​src/​metrics.rs	Exposes scan outcome metrics.
minter/​src/​main.rs	Registers the scan timer.
minter/​src/​deposit/​automatic/​scan/​tests.rs	Tests scan behavior and scheduling.
minter/​src/​deposit/​automatic/​scan/​mod.rs	Implements watched-address scanning.
minter/​src/​deposit/​automatic/​mod.rs	Exports scan functionality.
minter/​src/​constants.rs	Defines the scan interval.
integration_tests/​tests/​tests.rs	Tests timer-based deposit detection.
integration_tests/​src/​fixtures.rs	Adds batched-account RPC mocks.
docs/​src/​development/​design.md	Updates scan behavior and cost bounds.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The scan can race with a pending manual deposit call and cause a duplicate-queue assertion.

3 open findings

• Prevent duplicate deposit queueing during scan and deposit interleaving
• Late scan completion shifts fixed schedule slots
• Document typed getMultipleAccounts endpoint requirement

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Mainnet deposit queueing and asynchronous interactions with manual deposits warrant final human validation.

3 open findings

• Prevent duplicate deposit queueing during scan and deposit interleaving
• Late scan completion shifts fixed schedule slots
• Remove extra space before opening brace · New

1 resolved since last review

• Document typed getMultipleAccounts endpoint requirement

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Asynchronous interactions between automatic scans, manual deposits, and fee charging in the mainnet financial flow warrant final human validation.

No open issues 🎉

4 resolved since last review

• Prevent duplicate deposit queueing during scan and deposit interleaving
• Late scan completion shifts fixed schedule slots
• Remove extra space before opening brace
• Document typed getMultipleAccounts endpoint requirement

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues require changes.

No open issues 🎉

_{Review effort: Balanced}

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 1f09987.

Security Overview

• 🔎 Scanned files: 15 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/58f1cdfe-c0c2-41c1-8d28-3d6efcaf3266?scanId=83208592-2007-4d53-a2cf-7d4b5f7a0f2c&codeScanTypes=PrScan&tab=issues&detectionTypes=traditional,businessLogic,customRule,IAC,SECRETS,CICD,EOL,uncategorized

Detected Code Changes

Change Type

Relevant files

Enhancement

► minter/src/deposit/automatic/mod.rs     +pub use crate::constants::SCAN_WATCHED_ADDRESSES_DELAY; ► minter/src/deposit/automatic/scan/mod.rs -new file defining scan logic for watched addresses, including scan_watched_addresses function, balance read application, and related types and helpers ► minter/src/deposit/automatic/scan/tests.rs -new tests for automatic scan behavior and balance reads ► integration_tests/src/fixtures.rs +Mock for getMultipleAccounts call and getMultipleAccounts response builder functions ► integration_tests/tests/tests.rs -tests extending automatic deposit flow with scan delay and balance scenarios ► minter/src/constants.rs +SCkAN_WATCHED_ADDRESSES_DELAY constant definition for scan interval ► minter/src/deposit/automatic/mod.rs -export of SCAN_WATCHED_ADDRESSES_DELAY via pub use and integration with scan module ► minter/src/deposit/automatic/scan/mod.rs (new module) and its implementations ► minter/cksol_minter.did -documentation update describing deposit queuing behavior when deposits already in flight or balances scanned during automatic flow ► minter/src/deposit/automatic/scan/tests.rs (new tests)