Repository navigation
Conversation
Signed-off-by: Dundy Pasupuleti <dundysm@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1022
MultibodyJointSet::do_insertcreated a root multibody and a connectivity graph node for every endpoint not yet in the set, and only then checked whether the insertion was valid. so:insert(body, body, ..)created two provisional roots, merged them and returnedSomefor a self joint;insert(fresh, child, ..)wherechildalready has a parent returnedNonebut left a root multibody and a graph node behind forfresh.this does the checks first, from the existing
rb2mbentries: identical handles are rejected, abody2that already has a parent is rejected, and two bodies already in the same multibody are rejected. the provisional roots are only created once the insertion is known to succeed; the rest of the function is unchanged.added
crates/rapier3d/tests/issue_1022_multibody_rejected_insert.rs; on master the self joint is accepted and ten rejected inserts leave 11 multibodies instead of 1; both tests pass with the change.cargo testpasses for rapier3d and rapier2d, and clippy is clean.