Repository navigation
Conversation
Base: 475caa3 Patch-SHA256: befebc76a83bfe734bb8205dd7f2537ad2c6f06cc5262e160b56d1a1729e5b39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2D staged-solver test constructs a translation with
i as f32. In the parallelrapier2d-f64library build, the translation requiresReal, so the fixture fails tocompile. Cast the index to
crate::math::Real, preserving the fixture values whilefollowing the selected scalar precision.
This changes one test expression and no runtime source. The pinned four-crate native
default/parallel library and integration matrices pass with this correction, including
the 2D/f64 parallel target. Those isolated checks also contained a separate origin proposal;
the origin feature is not included here.
cargo test -p rapier2d-f64 --lib --features parallel