Skip to content

Remove redundant casts from native test fixtures - #1062

Open
partaevil wants to merge 1 commit into
dimforge:masterfrom
partaevil:fix/native-test-casts
Open

partaevil wants to merge 1 commit into
dimforge:masterfrom
partaevil:fix/native-test-casts

Conversation

@partaevil

Copy link
Copy Markdown

Strict Clippy rejects two existing test expressions on the pinned base: TAU as Real
casts f32 to f32 in the rapier2d soft-recovery integration fixture, and -1.0 as Real
is a redundant literal cast in the shared dim2 soft-contact unit test.

Remove the first cast and give the second tuple an explicit (u32, u32, Real) type.
The values and assertions remain the same; both edits are in tests and no non-test source
changes.

The failures were reproduced against the original upstream file hashes. With these
corrections, strict library/test Clippy passes for all four native dimension/precision
crates in default and parallel configurations. Complete isolated library/integration
matrices pass (723 default / 737 parallel tests). Those matrices also contained separate
origin, documentation and parallel-fixture patches; none is included in this PR.

cargo clippy -p rapier2d -p rapier3d -p rapier2d-f64 -p rapier3d-f64 --lib --tests -- -D warnings
cargo clippy -p rapier2d -p rapier3d -p rapier2d-f64 -p rapier3d-f64 --lib --tests --features parallel -- -D warnings

Base: 475caa3
Patch-SHA256: 6e8c15310331c3823d0b5883465406f40c120c18b0929077bbdfea45cbf69283

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant