Repository navigation
core: use CowByteArray everywhere possible - #48464
Merged
Merged
Conversation
jkarneges
force-pushed
the
jkarneges/core-cowbytearray
branch
from
October 28, 2026 17:07
571dfbb to
4d42f31
Compare
clintjedwards
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #48459 which targeted headers, this PR replaces as many uses of
QByteArraywithCowByteArrayas possible in the rest of the core module, without removing compatibility code.With this, all use of
QByteArrayis eliminated from the core module except:.asQByteArray(). These uses will go away as we migrate away from these other APIs.CowByteArray. This use will go away when it is the only usage remaining and we swap it out for a non-Qt implementation.