Repository navigation
Prepare 1.0.0-rc.1 release - #113
Merged
Merged
Conversation
Move the release version into a VERSION file at the repo root, read by a new Directory.Build.props. Both packages used to carry their own <Version>, and they have to match: the Aspire package pins its container image tag to its own version. One file means a release bump is a one-line change and the two can't drift. The Dockerfile copies VERSION and Directory.Build.props in before the restore step, because that layer is built before the rest of the source is copied. Log the emulator's version as the first line on startup (#89). The version lookup that already fed the dashboard moves into a shared EmulatorVersion class, so the log line and the dashboard read it the same way. Bump to 1.0.0-rc.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89. Prepares the 1.0.0-rc.1 release.
Version in one place
Adds a
VERSIONfile at the repo root (1.0.0-rc.1). A newDirectory.Build.propsreads it into<Version>, and the per-project<Version>elements are removed from both csproj files.The two packages have to match: the Aspire package pins its container image tag to its own version (#83), so it pulls
ghcr.io/feature23/azuresearchemulator:<its version>. With one file, a version bump is a one-line change and the two can't get out of sync.DockerfilecopiesVERSIONandDirectory.Build.propsin before the restore layer.VERSIONinstead of the csproj.Print the version on startup (#89)
The emulator now logs its version as the first line on startup:
The version lookup the dashboard already used moves out of
EmulatorStatusServiceinto a sharedEmulatorVersionclass. The log line and the dashboard now use the same value. A new unit test checks that it matchesVERSION.Verified
dotnet packproducesAzureSearchEmulator.1.0.0-rc.1andF23.Aspire.Hosting.AzureSearchEmulator.1.0.0-rc.1.After merge
Tag the merge commit
v1.0.0-rc.1and push the tag. That runs the NuGet and Docker publish workflows. Then create the GitHub Release as a pre-release.🤖 Generated with Claude Code