Skip to content

Use CMake's add_compile_definitions instead of add_definitions - #2249

Merged
Rangi42 merged 1 commit into
gbdev:masterfrom
Rangi42:add-compile-definitions
Nov 21, 2026
Merged

Rangi42 merged 1 commit into
gbdev:masterfrom
Rangi42:add-compile-definitions

Conversation

@Rangi42

@Rangi42 Rangi42 commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

The latter "has been superseded", and the former handles the platform-specific -D or /D syntax.

(Also, I think that /_MSVC_STL_HARDENING=1 /_MSVC_STL_DESTRUCTOR_TOMBSTONES=1 were not actually working, since they should have been /D_MSVC_STL_HARDENING=1 /D_MSVC_STL_DESTRUCTOR_TOMBSTONES=1.)

The latter "has been superseded", and the former handles the
platform-specific `-D` or `/D` syntax.
@Rangi42 Rangi42 added this to the 1.0.5 milestone Nov 21, 2026
@Rangi42 Rangi42 added meta This isn't related to the tools directly: repo organization, maintainership... builds This affects the build process or release artifacts labels Nov 21, 2026
@Rangi42
Rangi42 merged commit b47eb31 into gbdev:master Nov 21, 2026
31 checks passed
@Rangi42
Rangi42 deleted the add-compile-definitions branch November 21, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant