Repository navigation
Avoid quadratic scans in timeline pagination - #7973
Open
cleanunicorn wants to merge 1 commit into
Open
cleanunicorn wants to merge 1 commit into
cleanunicorn wants to merge 1 commit into
Conversation
cleanunicorn
marked this pull request as ready for review
November 21, 2026 06:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Latest timeline pagination finds older rows that changed inside the window and includes the updates when they fit the byte budget. To calculate which rows still count toward the older-history marker, it searched that update list once per omitted row. When many omitted rows changed, those searches took quadratic time.
What changed
Use the same sequence cutoff in the omitted-row reduction when the updates fit. Each omitted row then takes constant time to classify. When the updates exceed the byte budget, all omitted rows still contribute to the marker. The response shape, update ordering, and byte accounting stay the same.
How you verified
Fixes #7972