Repository navigation
Conversation
These were removed from being packaged on v1.57. This change instead removes it from being substituted, but only from the `--host_substitution=all` flow, to preserve the `--host_substitution=only` end-to-end test. Bug: b/554100008
Databean
force-pushed
the
no_substitute_netsim_secure_env
branch
from
October 27, 2026 01:01
63ba116 to
780c662
Compare
rmuthiah
requested changes
Oct 27, 2026
| // TODO(schuffelen): actually substitute things when migrations are complete | ||
| if (StringFromEnv("CVD_FORCE_SUBSTITUTE").value_or("") != "true") { | ||
| std::string base = android::base::Basename(full_link_name); | ||
| if (base == "netsim" || base == "netsimd" || base == "secure_env") { |
Collaborator
There was a problem hiding this comment.
Didn't we also want to include crosvm here per our last discussion?
If I recall correctly, crosvm didn't substitute cleanly and made snapshotting unreliable if it was.
Member
Author
There was a problem hiding this comment.
It's still included in the latest release attempt, removing it from the substitution list was the fallback option. The snapshotting issues seem to be fixed with the latest changes.
Databean
enabled auto-merge
October 28, 2026 19:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were removed from being packaged on v1.57. This change instead removes it from being substituted, but only from the
--host_substitution=allflow, to preserve the--host_substitution=onlyend-to-end test.Bug: b/554100008