Skip to content

Fix CI on main: drop unused event bindings in the resize handle - #5

Open
tarc wants to merge 1 commit into
gpui-ce:mainfrom
tarc:fix/resize-handle-unused-ev
Open

tarc wants to merge 1 commit into
gpui-ce:mainfrom
tarc:fix/resize-handle-unused-ev

Conversation

@tarc

@tarc tarc commented Oct 1, 2026

Copy link
Copy Markdown

main fails CI on every platform since #4: the Lint job and the Linux, macOS and Windows test jobs all stop at the same three warnings, which CI turns into errors.

crates/base/src/resizable/resize_handle.rs:391:23: unused variable: `ev`
crates/base/src/resizable/resize_handle.rs:404:23: unused variable: `ev`
crates/base/src/resizable/resize_handle.rs:427:23: unused variable: `ev`

#4 switched these listeners from is_hovered_at(ev.position) to is_hovered(window), so the event argument is no longer read. This PR binds it as _, the way these closures already ignore their other unused arguments.

Testing (Windows 11, MSVC, native)

  • cargo clippy --locked --workspace --all-targets -- -D warnings: fails on main with the three errors above, clean with this PR.
  • cargo test --locked --workspace on main (c082069): all tests pass, about 1,980 in total, including gpui_component (616), gpui_base (1,225) and gpui_fps (34). This change doesn't affect them.

The GPUI Shell jobs in ci.yml will keep failing: they test the shell crates #4 removed. I left the workflow alone, since how to handle those jobs is a maintainer decision.

AI disclosure: the fix, the testing and this description were done with Claude (an AI assistant). I reviewed them.

🤖 Generated with Claude Code

https://claude.ai/code/session_01J7JQV1YRa9p7viwjBUskzm

The handle's mouse listeners check the hitbox with is_hovered(window)
since the move to GPUI CE 0.2.2, so the event argument goes unused. CI
denies warnings, and the three `unused variable: ev` warnings fail
every test job and the lint job on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J7JQV1YRa9p7viwjBUskzm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant