Repository navigation
Conversation
The handle's mouse listeners check the hitbox with is_hovered(window) since the move to GPUI CE 0.2.2, so the event argument goes unused. CI denies warnings, and the three `unused variable: ev` warnings fail every test job and the lint job on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J7JQV1YRa9p7viwjBUskzm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfails CI on every platform since #4: the Lint job and the Linux, macOS and Windows test jobs all stop at the same three warnings, which CI turns into errors.#4 switched these listeners from
is_hovered_at(ev.position)tois_hovered(window), so the event argument is no longer read. This PR binds it as_, the way these closures already ignore their other unused arguments.Testing (Windows 11, MSVC, native)
cargo clippy --locked --workspace --all-targets -- -D warnings: fails onmainwith the three errors above, clean with this PR.cargo test --locked --workspaceonmain(c082069): all tests pass, about 1,980 in total, includinggpui_component(616),gpui_base(1,225) andgpui_fps(34). This change doesn't affect them.The
GPUI Shelljobs inci.ymlwill keep failing: they test the shell crates #4 removed. I left the workflow alone, since how to handle those jobs is a maintainer decision.AI disclosure: the fix, the testing and this description were done with Claude (an AI assistant). I reviewed them.
🤖 Generated with Claude Code
https://claude.ai/code/session_01J7JQV1YRa9p7viwjBUskzm