Repository navigation
Support stable GPUI CE 0.3 - #6
Merged
Merged
Conversation
Lots of failures like these, are you able to resolve them to the best of your ability? |
Author
|
@philocalyst builds now on Linux |
philocalyst
marked this pull request as ready for review
October 26, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the CE workspace from GPUI 0.2.2 to the stable 0.3.0 core, platform, macros, and web releases. Applications using
gpui-tray0.3 can then share one GPUI package with components.The port adapts shaping, backend caret/cluster geometry, visual-line and shimmer painting, masks, shadow backgrounds, window activation, inspector registration, and profiler frame events. An internal compatibility wrapper preserves the editor's UTF-8 boundaries, indentation, and atomic inline elements while measuring fallback glyphs through the new shaper. Custom selectable text and shimmer keep an independent layout node so automatic inline flow cannot bypass their measurement. The obsolete resolved-system-font reverse lookup is removed because 0.3 caches font resolution.
Draft: the 29 original library regressions are resolved. The current Linux library run passes 1,227 Base tests and 578 Component tests, with one existing Component ignore. The full non-WebView workspace passes, and refreshed native CI is pending; Story interaction and platform performance still need validation. No assertions were disabled or marked ignored to hide failures.
AI assistance: implemented and reviewed with Codex. Validation and its limitations are reported below.
Public API
gpui-base
StyledExt::refine_style(self, style: &StyleRefinement) -> Self. GPUI 0.3 supplies the same builder ongpui::Styled, avoiding ambiguous method calls. The wrapping and caret compatibility module is internal.gpui-component
gpui_base::StyledExthas the same method removal. Other widget and theme APIs keep their existing paths.gpui-kit
Breaking Changes
Use GPUI's
Styledtrait for the style refinement builder:Keep direct GPUI dependencies aligned with components:
How to Test
cargo fmt --all --checkandgit diff --check.--all-targets --features gpui-component-story/test-support -- -D warnings, excluding the WebView library/example because WebKitGTK is unavailable locally. This includes Story, examples, and integration-test type checking.cargo test -p gpui_ce_components_base -p gpui_ce_components --features gpui_ce_components/test-support --lib --no-fail-fast: Base 1,227 passed; Component 578 passed, 1 existing ignore.cargo machete.cargo check -p gpui_ce_components --no-default-features --lockedand the no-default-features library/callback/legacy-compatibility suites: 571 library tests plus 6 integration tests passed, 1 existing ignore.The cleanup restores
Icon::datarendering throughSvg::data, fixes the macOS test-support feature guard, migrates inherited CI jobs and package/version checks to this CE workspace, and removes unused dependencies. Shared example imports hidden from cargo-machete by#[path]are documented exceptions.Actual compatibility fixes include constrained rich-text wrapping, direct caret lookup for reveal requests, Command style invalidation and safe first-frame shortcut lookup, and a flex-column Dialog body that keeps its scroll viewport within the capped panel. Test fixtures now use real Parley shaping with bundled fonts for wrapping, actual viewport sizes, deliberate renderer invalidation, and the scheduler clock for animations. The Base suite completes in about four seconds; the old reveal cluster walk made one test alone take several minutes with real shaping.
See
docs/GPUI-CE-0.3.mdfor migration details. The twotext_compattests still cover Unicode caret round trips and multi-byte atomic element ranges using bundled IBM Plex. All seven native-menu tests pass on Linux.Checklist
cargo runfor related Story tests.Native menu CI follow-up
Both native menu backends and their icon loader use
App::assets/AssetRegistry, including borrowed/optional registry loads. Tests cover preloaded and on-demand entries, relative-path shadowing, absolute paths, and inline SVG data. FactorSeal's macOS and Windows CI verified consuming builds; this PR's refreshed platform matrix must still verify the full component workspace.Current CI status
The pushed cleanup commits have no new GitHub check runs registered yet. The earlier failures shown on the original head do not validate these changes. Native CI and the WebView build remain outstanding; the PR stays draft.