Skip to content

fix(cli): check says how many browser-playable copies are done while it makes them - #6712

Merged
miguel-heygen merged 1 commit into
mainfrom
checklong/plain-copy-lines
Oct 29, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
checklong/plain-copy-lines

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What changed

While check makes browser-playable copies of media Chrome cannot decode, its progress line named one file and a percentage, so a project with dozens of clips read as an endless run on one file. The line now says how many copies are done of how many: "making browser-playable copies: 1 of 3 done. clip.mov: 40% (1m 10s so far)". It still prints every 10 s. The Desktop app relays these lines live to its agent's shell.

What I measured

checkBrowser.test.ts passes (65 tests) and the two files are formatted. With checkBrowser.ts back at main's version the two heartbeat tests (the copy line and a finished copy no longer reported) fail (63 pass, 2 fail).

What I did NOT exercise

A real project with dozens of HEVC clips; the tests use a fake clock and a stand-in transcoder.

Why under 100 lines

A counter, a total, and one reworded line, plus the two assertions.

fails without the fix: says how far a copy has got every few seconds, so a slow copy reads as slow

@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 130 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 0 blocker · 0 important · 1 nit · head fbdcc999

  • nit: two counts now go to the same stream. browser-playable copies: N/total (checkBrowser.ts:255) counts cached files in both the count and the total. The heartbeat's X of Y done counts only the copies being made. With 2 cached and 1 to make, it prints 2/3 next to 0 of 1 done. The heartbeat matches the intro line ("copies of 1 video"), so this is a choice, but one shared count would read cleaner.
Scope

Read the whole diff and resolveProxies' settle path. A failed copy also counts as "done", which fits "finished". Locally: checkBrowser.test.ts 65/65 at the head. With main's checkBrowser.ts, the named test and its sibling fail (63 pass, 2 fail). CI is green. Windows engine-cli hit its 16-minute deadline once with no failing test, and the rerun was green. The Desktop side (agentSteps.test.mjs) relays raw lines and does not parse the old wording.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 2f8c4b1 Oct 29, 2026
77 of 79 checks passed
@miguel-heygen
miguel-heygen deleted the checklong/plain-copy-lines branch October 29, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant