Repository navigation
fix(cli): check says how many browser-playable copies are done while it makes them - #6712
Merged
Merged
Conversation
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 130 of thoseThe gate passes. Quarantined, measured but not gated (0) |
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 1 nit · head fbdcc999
- nit: two counts now go to the same stream.
browser-playable copies: N/total(checkBrowser.ts:255) counts cached files in both the count and the total. The heartbeat'sX of Y donecounts only the copies being made. With 2 cached and 1 to make, it prints2/3next to0 of 1 done. The heartbeat matches the intro line ("copies of 1 video"), so this is a choice, but one shared count would read cleaner.
Scope
Read the whole diff and resolveProxies' settle path. A failed copy also counts as "done", which fits "finished". Locally: checkBrowser.test.ts 65/65 at the head. With main's checkBrowser.ts, the named test and its sibling fail (63 pass, 2 fail). CI is green. Windows engine-cli hit its 16-minute deadline once with no failing test, and the rerun was green. The Desktop side (agentSteps.test.mjs) relays raw lines and does not parse the old wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
While
checkmakes browser-playable copies of media Chrome cannot decode, its progress line named one file and a percentage, so a project with dozens of clips read as an endless run on one file. The line now says how many copies are done of how many: "making browser-playable copies: 1 of 3 done. clip.mov: 40% (1m 10s so far)". It still prints every 10 s. The Desktop app relays these lines live to its agent's shell.What I measured
checkBrowser.test.tspasses (65 tests) and the two files are formatted. WithcheckBrowser.tsback at main's version the two heartbeat tests (the copy line and a finished copy no longer reported) fail (63 pass, 2 fail).What I did NOT exercise
A real project with dozens of HEVC clips; the tests use a fake clock and a stand-in transcoder.
Why under 100 lines
A counter, a total, and one reworded line, plus the two assertions.
fails without the fix: says how far a copy has got every few seconds, so a slow copy reads as slow