Skip to content

fix(cli): beats uses the only <audio> and lists the candidates when none is marked - #6714

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/beats-single-audio
Open

miguel-heygen wants to merge 1 commit into
mainfrom
fix/beats-single-audio

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Why

hyperframes beats failed with "No music track found" for a project whose single <audio> has no data-timeline-role="music" and no id like music, bgm or soundtrack, even though there was only one candidate. With several unmarked <audio> elements the error did not say which ones it saw or how to pick one.

What

  • findMusicAudioSrc (core) falls back to the composition's only unmarked <audio>: one with a src, no data-timeline-role and no music id. An explicit non-music role still excludes an element, and a marked track still wins.
  • New unmarkedAudioSources (core) lists those elements; the CLI uses it for the error.
  • With several unmarked <audio> elements the CLI fails, also with --json, and lists each id and src and how to mark one (data-timeline-role="music", or an id like music/bgm/soundtrack). A composition with no audio at all still answers --json with track: null.
  • Docs and the CLI skill reference name the new rule.

What I measured

  • Core beatFile.test.ts 43 pass and CLI beats.test.ts 27 pass; three runs in a row, same result.
  • fails without the fix: with the original beatFile.ts and beats.ts (core rebuilt from the original source), 3 CLI tests fail (uses the only <audio>; lists the unmarked elements with --json and without) and 2 core tests fail (only audio is the music track; several are listed, not guessed).
  • Tests ran on a Linux box with the CI package builds in place.

What I did NOT exercise

  • No real project on a published CLI build; the CLI tests analyze generated audio files through the command's run.
  • Several <audio> elements where Studio's longest-clip fallback would pick one: the CLI does not guess among them, it asks you to mark one.

@mintlify

mintlify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
hyperframes 🟢 Ready View Preview Oct 29, 2026, 4:38 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 148 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

This branch was successfully deployed

1 active deployment
staging - docs — 6c09af39 Deployed Oct 29, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant