Repository navigation
fix(cli): beats uses the only <audio> and lists the candidates when none is marked - #6714
Open
miguel-heygen wants to merge 1 commit into
Open
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
miguel-heygen
force-pushed
the
fix/beats-single-audio
branch
from
October 29, 2026 04:31
00a74eb to
6c09af3
Compare
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 148 of thoseThe gate passes. Quarantined, measured but not gated (0) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
hyperframes beatsfailed with "No music track found" for a project whose single<audio>has nodata-timeline-role="music"and no id likemusic,bgmorsoundtrack, even though there was only one candidate. With several unmarked<audio>elements the error did not say which ones it saw or how to pick one.What
findMusicAudioSrc(core) falls back to the composition's only unmarked<audio>: one with asrc, nodata-timeline-roleand no music id. An explicit non-music role still excludes an element, and a marked track still wins.unmarkedAudioSources(core) lists those elements; the CLI uses it for the error.<audio>elements the CLI fails, also with--json, and lists each id and src and how to mark one (data-timeline-role="music", or an id like music/bgm/soundtrack). A composition with no audio at all still answers--jsonwithtrack: null.What I measured
beatFile.test.ts43 pass and CLIbeats.test.ts27 pass; three runs in a row, same result.beatFile.tsandbeats.ts(core rebuilt from the original source), 3 CLI tests fail (uses the only<audio>; lists the unmarked elements with--jsonand without) and 2 core tests fail (only audio is the music track; several are listed, not guessed).What I did NOT exercise
run.<audio>elements where Studio's longest-clip fallback would pick one: the CLI does not guess among them, it asks you to mark one.