Repository navigation
refactor(cli): proxy failure wording without added comments or a try/catch - #6715
Open
miguel-heygen wants to merge 1 commit into
Open
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 154 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head df71defe
URL.canParse gives the same host-or-"the site" result as the removed try/catch, and the CLI requires Node ≥22, which has it. CI, Comments and Windows render are green on this head. This is a refactor, not a fix, so it needs no fails-without test.
— Genesis
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Follow-up to the merged capture proxy message: the two docblocks and the
// expected:comment innavigateForCapture.tsare removed, and the emptytry/catcharound the address parse becomesURL.canParse. The messages and behavior are unchanged.Why
The
Commentsworkflow's comment ratchet reported the file's comment share going from 0 to 1.4% on the merged change and asked for the lines to go, not to be shorter.Testing
navigateForCapture.test.tspasses (37 tests) with the change; format and lint are clean on the file.no behavior change
fails without the fix: not a behavior change; the
Commentsworkflow is the check.