Repository navigation
Conversation
…Link The standalone Link variant has a line-height equal to its font size. Since the text moved from TruncateText into a span with overflow hidden (for the CSS ellipsis), that span clipped the bottom of letters like "g" and "y". The text span now sets its own 1.5 line-height, which restores the 24px link height. INSTUI-5250 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (7)breadcrumb-canvas.png — 9073 pixels differbreadcrumb-dark.png — 12266 pixels differbreadcrumb-light.png — 12167 pixels differimagecard-light.png — 10211 pixels differtooltip-canvas.png — 339 pixels differtooltip-dark.png — 399 pixels differtooltip-light.png — 382 pixels differBaselines come from the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
line-height: 1.5on theBreadcrumb.Linktext span. The standalone Link line-height equals the font size, and the span'soverflow: hidden(used for the CSS ellipsis) clipped descenders. This restores the 24px link height from v11.6.Test Plan
Fixes INSTUI-5250
🤖 Generated with Claude Code