Skip to content

fix(ui-calendar): add an accessible name to the calendar table - #2795

Open
matyasf wants to merge 1 commit into
masterfrom
fix/INSTUI-5251-calendar-table-accessible-name
Open

matyasf wants to merge 1 commit into
masterfrom
fix/INSTUI-5251-calendar-table-accessible-name

Conversation

@matyasf

@matyasf matyasf commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Label the Calendar <table> with the visible month and year via aria-label (v1 and v2)
  • Include the year even when withYearPicker moves it out of the heading

Test Plan

  • With a screen reader, navigate to the calendar table and confirm it announces the month and year (e.g. "December 2023")

Fixes INSTUI-5251

🤖 Generated with Claude Code

@matyasf matyasf self-assigned this Nov 12, 2026
@matyasf
matyasf requested review from HerrTopi and balzss November 12, 2026 14:26

@balzss balzss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap is failing, i think thats a trivial typescript issue

Screen readers announced the table without saying which month it showed. The label includes the
year even when `withYearPicker` moves it out of the heading.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@matyasf
matyasf force-pushed the fix/INSTUI-5251-calendar-table-accessible-name branch from fb81283 to 6901e32 Compare November 13, 2026 12:51
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2795/

Built to branch gh-pages at 2026-11-13 12:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

github-actions Bot pushed a commit that referenced this pull request Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Visual regression report

Cypress suite: ✅ Passing

Visual diff: ✅ No changes.

Status Count
Unchanged 111
Changed 0
New 0
Removed 0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.

@matyasf
matyasf requested a review from balzss November 13, 2026 13:02
@matyasf

matyasf commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

bootstrap is failing, i think thats a trivial typescript issue

fixed it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants