Repository navigation
Conversation
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (3)view-canvas.png — 2204 pixels differview-dark.png — 2288 pixels differview-light.png — 281 pixels differBaselines come from the |
…itly undefined
React 19 does not resolve defaultProps on the forwardRef wrapper that withStyle and
withStyleNew create, and the wrapper's `{ ...defaultProps, ...props }` merge let an
explicit `undefined` overwrite the default. generateStyle therefore saw `undefined`
while the wrapped class still got its default, so `<View borderColor={undefined} />`
rendered without a border color.
The Link `iconPlacement` default in styles.ts only existed to paper over this and is
removed.
Co-Authored-By: Claude <noreply@anthropic.com>
matyasf
force-pushed
the
fix/instui-5252-undefined-default-props
branch
from
November 13, 2026 12:36
dc085e0 to
86017ba
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
withStyle/withStyleNewno longer let an explicitundefinedprop overwrite its default when computing styles, so<View borderColor={undefined} />looks the same in React 18 and 19iconPlacement = 'start'workaround from Link v1 and v2styles.ts, which only existed because of thisTest Plan
regression-testapp (React 19.3.0) and compare the border color with React 18<Link renderIcon={...} iconPlacement={undefined}>puts the icon before the textFixes INSTUI-5252
🤖 Generated with Claude Code