Skip to content

docs(__docs__): Enable light institution theming override examples, split institutional theming into its own pages - #2797

Open
matyasf wants to merge 1 commit into
masterfrom
docs/institutional-theming
Open

matyasf wants to merge 1 commit into
masterfrom
docs/institutional-theming

Conversation

@matyasf

@matyasf matyasf commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Move the branding sections out of the legacy and new theme override docs into "Legacy institutional theming" and "New institutional theming" pages, leaving a link behind
  • Pin legacy-institutional-theming to v11_6 in the docs app so its ic-brand-* examples work
  • Enable the light theme in the new branding examples, with a themed container background

Test Plan

  • Open the legacy institutional theming page: it should land on /v11_6/... with no version banner, and editing ic-brand-primary should recolor the preview
  • On the new page, switch the base theme between canvas and light in all four examples and check the overrides apply
  • Check that the links from both override docs and the sidebar in themes/theming/.. look right

🤖 Generated with Claude Code

The docs app pins theming pages to a component version by page id, so the
legacy page needs to be registered to render under v11_6 where its ic-brand-*
overrides take effect. The new page's branding examples now cover the light
theme.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@matyasf matyasf self-assigned this Nov 13, 2026
@matyasf
matyasf requested a review from balzss November 13, 2026 15:43
@matyasf matyasf changed the title docs(__docs__): split institutional theming into its own pages docs(__docs__): Enable light institution theming override examples, split institutional theming into its own pages Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2797/

Built to branch gh-pages at 2026-11-13 15:47 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

onChange={(_e, { value }) => setThemeName(value)}
>
<SimpleSelect.Option id="canvas" value="canvas">canvas</SimpleSelect.Option>
<SimpleSelect.Option id="light" value="light">light</SimpleSelect.Option>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples were updated, now they work with the light theme too

@matyasf
matyasf requested a review from HerrTopi November 13, 2026 15:48
@github-actions

Copy link
Copy Markdown
Contributor

Visual regression report

Cypress suite: ✅ Passing

Visual diff: ✅ No changes.

Status Count
Unchanged 111
Changed 0
New 0
Removed 0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.

github-actions Bot pushed a commit that referenced this pull request Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant