Repository navigation
Bundle the ro-efactura-v1 addon from gobl.ro.anaf - #75
Closed
teodor2002 wants to merge 3 commits into
Closed
teodor2002 wants to merge 3 commits into
teodor2002 wants to merge 3 commits into
Conversation
Approved as an external addon in invopop/gobl#1027. gobl.ro.anaf v0.5.0 needs the Romanian regime, so GOBL moves to the unreleased commit that merged it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 65.71% 65.83% +0.11%
==========================================
Files 53 53
Lines 2710 2710
==========================================
+ Hits 1781 1784 +3
+ Misses 822 819 -3
Partials 107 107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GOBL v0.512.0 changed the converter Import signature, so gobl.es.facturae, gobl.fr.ctc, gobl.ubl and gobl.cii move to their releases built on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things Added
Romanian add-on in the bundle
Blank import of
github.com/invopop/gobl.ro.anaf/addoninbundle/bundle.go, so silo, the builder and the CLI can validate and sign documents declaringro-efactura-v1(approved in invopop/gobl#1027).GOBL v0.512.0 and gobl.ro.anaf v0.6.0
v0.512.0 is the first GOBL release with the Romanian regime. It changed the converter
Importsignature, so these move to their releases built on it: gobl.es.facturae v0.30.0, gobl.fr.ctc v0.0.18, gobl.ubl v0.101.0 and gobl.cii v0.84.0. Alsogo 1.26.2and go-jose v4.1.6.TODO Before Merging
TestFormatLabels(editor/formats_test.go:16): gobl.fr.ctc v0.0.18 madecii+fr-ctc-facturx-cius-v1importable, so its label no longer ends in "(export only)". ZUGFeRD (cii+de-zugferd-v2) is now the only export-only formatTestExampleSamples/fr-en16931(editor/examples_test.go:99): an invoice exported ascii+fr-facturx-v1is now imported ascii+en16931-v2017. In gobl.fr.ctc v0.0.18 Factur-X shares the EN 16931 guideline ID, so import can't tell them apartgobl.devpin, sosilo.closeacceptsro-efactura-v1documents