Skip to content

Bundle the ro-efactura-v1 addon from gobl.ro.anaf - #75

Closed
teodor2002 wants to merge 3 commits into
mainfrom
bundle-ro-efactura
Closed

teodor2002 wants to merge 3 commits into
mainfrom
bundle-ro-efactura

Conversation

@teodor2002

@teodor2002 teodor2002 commented Nov 5, 2026 •

Copy link
Copy Markdown

Things Added

Romanian add-on in the bundle
Blank import of github.com/invopop/gobl.ro.anaf/addon in bundle/bundle.go, so silo, the builder and the CLI can validate and sign documents declaring ro-efactura-v1 (approved in invopop/gobl#1027).

GOBL v0.512.0 and gobl.ro.anaf v0.6.0
v0.512.0 is the first GOBL release with the Romanian regime. It changed the converter Import signature, so these move to their releases built on it: gobl.es.facturae v0.30.0, gobl.fr.ctc v0.0.18, gobl.ubl v0.101.0 and gobl.cii v0.84.0. Also go 1.26.2 and go-jose v4.1.6.

TODO Before Merging

  • TestFormatLabels (editor/formats_test.go:16): gobl.fr.ctc v0.0.18 made cii+fr-ctc-facturx-cius-v1 importable, so its label no longer ends in "(export only)". ZUGFeRD (cii+de-zugferd-v2) is now the only export-only format
  • TestExampleSamples/fr-en16931 (editor/examples_test.go:99): an invoice exported as cii+fr-facturx-v1 is now imported as cii+en16931-v2017. In gobl.fr.ctc v0.0.18 Factur-X shares the EN 16931 guideline ID, so import can't tell them apart
  • Release gobl.dev and bump silo's gobl.dev pin, so silo.close accepts ro-efactura-v1 documents

Approved as an external addon in invopop/gobl#1027. gobl.ro.anaf v0.5.0
needs the Romanian regime, so GOBL moves to the unreleased commit that
merged it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.83%. Comparing base (f72c931) to head (6fb0481).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   65.71%   65.83%   +0.11%     
==========================================
  Files          53       53              
  Lines        2710     2710              
==========================================
+ Hits         1781     1784       +3     
+ Misses        822      819       -3     
  Partials      107      107              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

teodor2002 and others added 2 commits November 11, 2026 12:34
GOBL v0.512.0 changed the converter Import signature, so gobl.es.facturae,
gobl.fr.ctc, gobl.ubl and gobl.cii move to their releases built on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teodor2002 teodor2002 closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants