Skip to content

Bump GOBL to v0.512.0 - #77

Merged
cavalle merged 3 commits into
mainfrom
gobl-v0.512.0
Nov 11, 2026
Merged

cavalle merged 3 commits into
mainfrom
gobl-v0.512.0

Conversation

@cavalle

@cavalle cavalle commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings November 11, 2026 14:47
@codecov-commenter

codecov-commenter commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.72%. Comparing base (4317a29) to head (f1f99c2).

Files with missing lines Patch % Lines
editor/formats.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   65.83%   65.72%   -0.11%     
==========================================
  Files          53       53              
  Lines        2710     2719       +9     
==========================================
+ Hits         1784     1787       +3     
- Misses        819      822       +3     
- Partials      107      110       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Romanian converter import leaves format registration incomplete and its documented converter inventory out of sync, so the formats are not exposed consistently across the CLI, API, and editor.

2 open issues
What changed in this PR

Updates GOBL and related dependencies to v0.512.0, adds Romanian ANAF addon and converter support, and improves editor sample format detection.

Changes:

  • Bumps Go, GOBL, regional converter, addon, and indirect dependency versions.
  • Adds Romanian ANAF package imports to the shared bundle.
  • Validates exported editor samples through format detection and updates the related format label test.
File Description
go.sum Refreshes checksums for the upgraded and newly added dependencies.
go.mod Updates Go, GOBL, regional converter, addon, and related indirect dependency versions.
editor/​formats.go Verifies that exported samples are detected as their intended import format.
editor/​formats_test.go Updates the expected format label for the editor format test.
editor/​examples.go Passes source document data into editor sample importability checks.
bundle/​bundle.go Adds Romanian ANAF addon and converter package imports to the shared bundle.

Review effort: Lite

Comment thread bundle/bundle.go Resolved
Comment thread bundle/bundle.go Resolved
Lists them in the README's converter table, and adds a Romanian e-Factura
example to the editor so the UBL format can be tried out.
Copilot AI lite review requested due to automatic review settings November 11, 2026 15:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change has unresolved compatibility and coverage issues, including an unjustified Go 1.26.2 requirement and missing sample expectations that could allow the intended format preference to regress unnoticed.

4 open issues

Review effort: Lite

Comment thread go.mod Resolved
Comment thread editor/examples_test.go Resolved
Copilot AI lite review requested due to automatic review settings November 11, 2026 15:29

@alvarolivie alvarolivie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported, supporting approval of the dependency updates and Romanian e-Factura integration changes.

No open issues 🎉

4 resolved since last review

Review effort: Lite

@cavalle
cavalle merged commit bc7ee62 into main Nov 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants