Repository navigation
fix(footer): keep safe area padding until the webview resizes for the keyboard - #31693
Open
ShryukGrandhi wants to merge 1 commit into
Open
ShryukGrandhi wants to merge 1 commit into
ShryukGrandhi wants to merge 1 commit into
Conversation
… keyboard Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30268
What is the current behavior?
When the keyboard starts to open,
ion-footerremoves its bottom safe area padding as soon askeyboardWillShowfires. The webview has not resized yet at that point, so the footer gets shorter, the content gets taller, and content scrolled to the bottom shifts down before the keyboard appears. The footer already waits for the webview to resize when the keyboard closes, but not when it opens.What is the new behavior?
ion-apporbody) is no longer at its initial height. Closing behaves as before.ion-footerwaits for that promise in both directions before toggling the safe area padding, so the padding is removed in the same frame the webview shrinks.resize: none, SSR) no promise is returned and the footer updates immediately, as before.ion-tab-barstill hides immediately on open.ion-footerthat mocks the Capacitor Keyboard plugin and aResizeObserver.This covers only the footer padding part of the issue. The iOS plugin resizing after the animation and the scroll position are tracked in #28864 and #28226.
Does this introduce a breaking change?
Other information
Tested with
npx stencil test --spec -- src/components/footer src/components/tab-bar src/utils/keyboard. The new test fails without the change and passes with it.Fixes #30268