Skip to content

test(router-link): add screenshot and spec tests - #31703

Open
thetaPC wants to merge 2 commits into
ionic-modularfrom
FW-6903-tests
Open

thetaPC wants to merge 2 commits into
ionic-modularfrom
FW-6903-tests

Conversation

@thetaPC

@thetaPC thetaPC commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Issue number: internal


What is the current behavior?

ion-router-link has no screenshot or spec tests, only an axe check.

What is the new behavior?

  • Adds a screenshot of a default and a colored link in every theme, so the Modular Ionic migration has a baseline
  • Adds spec tests for the anchor attributes, the color classes, and how a click hands off to ion-router

Does this introduce a breaking change?

  • Yes
  • No

Other information

The spec tests fail if the router direction, the color classes or rel is dropped.

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Nov 6, 2026 12:12am UTC

Request Review

@thetaPC
thetaPC added this pull request to stack #31706 November 6, 2026 00:12
@thetaPC
thetaPC marked this pull request as ready for review November 6, 2026 04:08
@thetaPC
thetaPC requested a review from a team as a code owner November 6, 2026 04:08
@thetaPC
thetaPC requested a review from brandyscarney November 6, 2026 04:08

This branch was successfully deployed

1 active deployment
Preview — f2ee0b7f Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant