Skip to content

recalculate size when set() is given the same value again #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OsamaAnsar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

recalculate size when set() is given the same value again #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2291,6 +2291,10 @@ export class LRUCache<K extends {}, V extends {}, FC = unknown> {
}
}
} else if (!isBF) {
// same value, but it may have been mutated, or been given a
// different size, so the size still has to be recalculated.
this.#removeItemSize(index)
this.#addItemSize(index, size, status)
if (status) {
status.set = 'update'
}
Expand Down
343 changes: 343 additions & 0 deletions tap-snapshots/test/tracing.ts.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9115,16 +9115,20 @@ Array [
},
Object {
"cache": LRUCache [],
"entrySize": 2,
"key": 1,
"op": "set",
"set": "update",
"totalCalculatedSize": 2,
"value": 1,
},
Object {
"cache": LRUCache [],
"entrySize": 2,
"key": 1,
"op": "set",
"set": "update",
"totalCalculatedSize": 2,
"value": 1,
},
Object {
Expand Down Expand Up @@ -15482,6 +15486,345 @@ Map {
}
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value does not dispose it metrics 1`] = `
Array [
Object {
"cache": LRUCache [
Array [
"a",
Array [
1,
2,
3,
],
],
],
"entrySize": 1,
"key": "a",
"op": "set",
"set": "add",
"totalCalculatedSize": 1,
"value": Array [
1,
2,
3,
],
},
Object {
"cache": LRUCache [
Array [
"a",
Array [
1,
2,
3,
],
],
],
"entrySize": 3,
"key": "a",
"op": "set",
"set": "update",
"totalCalculatedSize": 3,
"value": Array [
1,
2,
3,
],
},
]
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value does not dispose it traces 1`] = `
Map {}
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value recalculates its size metrics 1`] = `
Array [
Object {
"cache": LRUCache [
Array [
"b",
Array [
0,
0,
0,
0,
0,
],
],
],
"entrySize": 3,
"key": "a",
"op": "set",
"set": "add",
"totalCalculatedSize": 3,
"value": Array [
1,
2,
3,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
],
},
Object {
"cache": LRUCache [
Array [
"b",
Array [
0,
0,
0,
0,
0,
],
],
],
"entrySize": 50,
"key": "a",
"op": "set",
"set": "update",
"totalCalculatedSize": 50,
"value": Array [
1,
2,
3,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
],
},
Object {
"cache": LRUCache [
Array [
"b",
Array [
0,
0,
0,
0,
0,
],
],
],
"entrySize": 60,
"key": "b",
"op": "set",
"set": "add",
"totalCalculatedSize": 60,
"value": Array [
0,
0,
0,
0,
0,
],
},
Object {
"cache": LRUCache [
Array [
"b",
Array [
0,
0,
0,
0,
0,
],
],
],
"get": "hit",
"key": "b",
"op": "get",
"value": Array [
0,
0,
0,
0,
0,
],
},
Object {
"cache": LRUCache [
Array [
"b",
Array [
0,
0,
0,
0,
0,
],
],
],
"entrySize": 5,
"key": "b",
"op": "set",
"set": "update",
"totalCalculatedSize": 5,
"value": Array [
0,
0,
0,
0,
0,
],
},
]
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value recalculates its size traces 1`] = `
Map {}
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value with a new explicit size metrics 1`] = `
Array [
Object {
"cache": LRUCache [],
"entrySize": 2,
"key": "a",
"op": "set",
"set": "add",
"totalCalculatedSize": 2,
"value": Object {},
},
Object {
"cache": LRUCache [],
"entrySize": 5,
"key": "b",
"op": "set",
"set": "add",
"totalCalculatedSize": 7,
"value": Object {},
},
Object {
"cache": LRUCache [],
"entrySize": 9,
"key": "a",
"op": "set",
"set": "update",
"totalCalculatedSize": 9,
"value": Object {},
},
Object {
"cache": LRUCache [],
"entrySize": 1,
"key": "a",
"op": "set",
"set": "update",
"totalCalculatedSize": 1,
"value": Object {},
},
Object {
"cache": LRUCache [],
"delete": "set",
"key": "a",
"op": "delete",
},
Object {
"cache": LRUCache [],
"key": "a",
"maxEntrySizeExceeded": true,
"op": "set",
"set": "miss",
"value": Object {},
},
]
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-setting the same value with a new explicit size traces 1`] = `
Map {}
`

exports[`test/tracing.ts > TAP > test/tracing.ts > TAP > re-use key before initial fill completed metrics 1`] = `
Array [
Object {
Expand Down
Loading