Repository navigation
test: synchronize diagnostics channel initialization on Node 26 - #420
Open
hafizahmedzia wants to merge 1 commit into
Open
hafizahmedzia wants to merge 1 commit into
hafizahmedzia wants to merge 1 commit into
Conversation
Prepared and validated with OpenAI Codex assistance.
isaacs
reviewed
Oct 19, 2026
| shell: bash | ||
| - os: windows-latest | ||
| shell: powershell | ||
| include: |
Owner
There was a problem hiding this comment.
Why not just add 26.x to the matrix? Does it fail on Windows still?
isaacs
marked this pull request as ready for review
October 19, 2026 19:46
|
As noted in #419, the issue no longer occurs, so I'm unsure about the necessity for this PR. Re-testing under Ubuntu 26.04.1 LTS with the following Node.js releases shows where it fails and then begins to pass:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Node 26 diagnostics-channel test failure in #419.
Wait for mocked tracing-channel initialization itself rather than assuming the dynamic import is still pending when
mockImportresolves. The real metrics/tracing checks and the failed-import dummy fallback remain covered. Add Ubuntu Node 26 as one extra CI matrix entry. No runtime implementation changes; Windows work in #413 remains separate.Validation
AI-assisted Linux checks against
7e71a1f3babdc68dfbadde91f28eaeea919dad9b:These are recorded local results, not actual GitHub Actions execution or all-file coverage. Other operating systems were not tested in this validation. Implementation, test execution and summary were prepared with OpenAI Codex assistance. Submitted as a draft for review.