Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zero gross return (a -100% return) currently makes geometric_mean return 0 instead of -1. Consequently, a backtest whose equity falls to zero reports Return (Ann.) as 0% even though Return is -100%.
Handle zero gross returns explicitly as a geometric mean return of -1. Preserve the existing behavior for negative gross returns, NaNs and empty inputs.
Tests cover total loss before and after positive returns, missing observations, ordinary positive growth factors, empty data, and an end-to-end leveraged strategy whose equity is exhausted. The independent product-root formula, and scipy.stats.gmean for zero gross returns, give -1. Reference: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.gmean.html .
Before: four total-loss helper subcases and the end-to-end annualized-return assertion fail. After: all 26 TestBacktest tests pass. flake8 on both changed files and git diff --check pass. Python 3.12.14, pandas 3.1.0, NumPy 2.5.4.
Full suite after installing test extras: 84 tests OK, 1 skipped. Existing pandas deprecation warnings remain. Mypy reports the same 10 errors in unchanged _plotting.py as the clean baseline (error lines compared identical).