Repository navigation
Conversation
Signed-off-by: Ayush <bhandariayush935@gmail.com>
👷 Deploy Preview for node-readiness-controller processing.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ayush4958 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for node-readiness-controller canceled.
|
|
Hi @Ayush4958. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Karthik-K-N |
|
/ok-to-test |
|
@Ayush4958: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
When new nodes join the cluster with
readiness.k8s.io/*taints, critical Infra DaemonSets (network & storage driver) can't schedule on them without explicit tolerations. This causes a deadlock where node can't become ready until those drivers runI had added automatic toleration injection for DaemonSets without requiring a separate webhook server:
MutatingAdmissionPolicyreads list & automatically add the missing tolerations to DaemonSets when they are created / updatedreadiness.k8s.io/auto-tolerate: falseRelated Issue
Closes #7
Type of Change
/kind feature
Testing
make testpassed across all packages./hack/verify-all.shpassedhelm lint& template rendering verifiedChecklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Generative AI Usage Disclosure
How they were used:
AI assisted with drafting the CEL expressions, helm templates and unit tests. All changes, failure modes, and test results were reviewed, debugged, and verified locally on kind by myself