Repository navigation
🩹 Fix PHP 8.5 deprecation for PDO::MYSQL_ATTR_SSL_CA - #149
Merged
Merged
Conversation
EOF Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without this change, Laracord cannot boot on PHP 8.5. Loading
config/database.phpduring provider registration emits a deprecation forPDO::MYSQL_ATTR_SSL_CA; Laravel's exception handler then tries to resolvelogbefore it is bound, so early bootstrap commands such aspackage:discoverfail withTarget class [log] does not exist.On PHP 8.5:
$ php laracord package:discover --ansi In Container.php line 1124: Target class [log] does not exist. In Container.php line 1122: Class "log" does not existPdo\Mysql::ATTR_SSL_CAwhenPHP_VERSION_ID >= 80500, otherwise fall back toPDO::MYSQL_ATTR_SSL_CA.Related to the v3 work in #134.
Test plan
php laracord package:discover --ansisucceeds (project is runnable)Constant PDO::MYSQL_ATTR_SSL_CA is deprecatednotice when the database config is loaded