[edwardalee]

No description provided.

[Copilot]

🟢 Approval recommended

No active review issues are reported for the clang-tidy cleanup across the runtime and examples.

No open issues 🎉

What changed in this PR

Addresses clang-tidy warnings causing CI failures across the reactor runtime and examples.

Changes:

• Replaces single-mutex std::lock_guard instances with std::scoped_lock.
• Adds explicit return types to callback and predicate lambdas.
• Converts ConnectionType to a scoped enum.

File	Description
lib/​scheduler.cc	Updates mutex guards and predicate return types.
lib/​port.cc	Adds an explicit return type to composed callbacks.
lib/​multiport.cc	Adds an explicit return type to the set callback.
lib/​environment.cc	Updates the shutdown guard and startup lambda.
include/​reactor-cpp/​time_barrier.hh	Adds an explicit boolean return type to the wait predicate.
include/​reactor-cpp/​semaphore.hh	Updates the release guard and acquire predicate.
include/​reactor-cpp/​multiport.hh	Adds an explicit return type to the cleanup callback.
include/​reactor-cpp/​impl/​action_impl.hh	Updates guards for asynchronous action scheduling.
include/​reactor-cpp/​connection.hh	Adds explicit return types to connection callbacks.
include/​reactor-cpp/​connection_properties.hh	Makes ConnectionType a scoped enum.
examples/​power_train/​main.cc	Adds explicit return types to reaction lambdas.
examples/​ports/​main.cc	Adds explicit return types to reaction lambdas.
examples/​hello/​main.cc	Adds explicit return types to reaction lambdas.
examples/​count/​main.cc	Adds explicit return types to reaction lambdas.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the clang-tidy cleanup.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues remain for the clang-tidy cleanup across the runtime and examples.

No open issues 🎉

_{Review effort: Balanced}

[edwardalee]

I've disabled treating warnings as errors in the benchmarks-lingua-franca repo, so these changes are no longer necessary. Anyway, they seem to result in the tests timing out.