Repository navigation
Fix "Test again" leaving the result screen on top - #59
Open
StarMusa88 wants to merge 1 commit into
Open
StarMusa88 wants to merge 1 commit into
StarMusa88 wants to merge 1 commit into
Conversation
"Test again" used the tab-switch helper, whose popUpTo(saveState) + restoreState immediately restored the result screen on top of the speedtest screen, so the test ran hidden behind the result and only appeared after pressing Back. Pop the result off the stack instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tapping Test again reused the tab-switch navigation helper, which does
popUpTo(start) { saveState = true }+restoreState = true. That saved the result screen and immediately restored it on top of the speedtest screen, so the restarted test ran hidden behind the result and only appeared after pressing Back.Fix
Pop the result off the back stack instead, then start the test:
Testing
./gradlew :app:lintDebug :app:testDebugUnitTest -Proborazzi.test.verify=truepasses.This change was developed with the help of OpenCode.