Repository navigation
File_Extractor: Support the 7z Delta filter - #553
Merged
Merged
Conversation
Archives made by current 7-Zip often pair LZMA2 with a Delta filter (the joshw.info Mega Drive VGM packs, for one). The bundled LZMA SDK 9.20 decoder only accepted BCJ and ARM as a second coder, so every file in such an archive failed with SZ_ERROR_UNSUPPORTED and would not play. Delta.c was already compiled in; wire it into CheckSupportedFolder and SzFolder_Decode2, as later LZMA SDK releases do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across a music archive compressed by 7-Zip with the Delta filter, which Cog couldn't open. This adds Delta to the bundled 7z decoder. It uses the
Delta.cthat already ships with the LZMA SDK copy in File_Extractor, so there are no new dependencies.Tested with a Debug build: the archive now opens and its tracks are listed.
As far as I can tell, this is in line with the project's conventions, a small and self-contained change inside the existing decoder. Thanks for Cog, it's a great player.