Repository navigation
ArchiveSource: Skip playlists inside archives - #554
Merged
Merged
Conversation
Container URLs aren't expanded a second time, so an m3u, m3u8 or pls inside an archive was added as a track that nothing can decode, showing a length of zero. Folders already leave playlists out by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A music archive I downloaded has a
!Playlist.m3ualongside its tracks. Dropping the archive into Cog added the playlist as an extra entry that won't play and shows 0:00. Container URLs aren't expanded a second time, so playlists (m3u,m3u8,pls) are now skipped, the same way folders skip them by default.Tested with a Debug build: dropping the archive lists only its tracks.
I think this keeps to how the codebase does things: a minimal change, confined to the plugin that lists an archive's contents. Cog is a wonderful player, thank you for it.