Repository navigation
Scope single-QSO QSL updates to the owning user - #3478
Merged
Merged
Conversation
Apply owner-only station_id scoping (matching Logbookadvanced_model bulk fix in #3477) to paperqsl_update, paperqsl_update_sent, and qsl_rcvd(). Return Error from qsl_rcvd_ajax and qsl_sent_ajax when no owned QSO matches. Spotted by raufaser in #3477. Co-authored-by: Peter Goodhall <magicbug@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #3477 scoped bulk QSL writes in
Logbookadvanced_modelto the requesting user's station profiles. The same primary-key-only gap remains on single-QSO paths:Qso::qsl_rcvd_ajax(),Qso::qsl_sent_ajax(), andLogbook_model::qsl_rcvd()(pluspaperqsl_update/paperqsl_update_sentused by the ajax handlers).Thanks to raufaser for spotting this while reviewing #3477.
Fix
Logbook_model::scopeQsosToUser()(same SQL pattern as Scope bulk QSO updates to the owning user #3477).paperqsl_update(),paperqsl_update_sent(), andqsl_rcvd()so updates only match QSOs whosestation_idbelongs to the session user (owner-only; shared-logbook writes unchanged from the bulk fix scope).qsl_rcvd_ajaxandqsl_sent_ajaxnow return{ "message": "Error" }when no owned row is updated (existing client failure shape).Testing
php -lon changed files (see CI / local PHP if unavailable in agent environment).