Repository navigation
AMSAT status: never hold up QSO saves - #3489
Merged
Merged
Conversation
Shorten cURL timeouts, skip slow dual-host retries, and stop retrying unknown_satellite when only the raw satellite name is available. Co-authored-by: Peter Goodhall <magicbug@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits how long inline AMSAT status uploads can block a satellite QSO save.
unknown_satelliteresponse is logged at info level and the upload stops without hitting the second host.Early response flush was not added:
upload_amsat_status()runs insideadd_qso()before the controller sends JSON (for exampleajax_saveqso), so callingfastcgi_finish_request()from the model would finish the request without the save response body.