Skip to content

docs: require mobile screenshots in PR delivery - #1087

Merged
boorad merged 1 commit into
mainfrom
fix/pr-screenshot-evidence
Oct 28, 2026
Merged

boorad merged 1 commit into
mainfrom
fix/pr-screenshot-evidence

Conversation

@boorad

@boorad boorad commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Make screenshot publication a required part of /pr delivery whenever a PR has mobile E2E evidence. Previously the workflow treated it as a separately authorized optional action, so #1057 shipped a signed attestation without its captured screenshots.

  • Require both final-run screenshots, bound to the same PR head and attestation, and report the screenshot-comment URL.
  • Treat missing credentials/artifacts or failed uploads as outstanding delivery blockers; /pr authorizes publication without another confirmation.
  • Keep policy-exempt PRs without mobile runs explicitly not applicable.
  • Document an owner-private local ImgBB credential at ~/.config/rnqc/imgbb-api-key and the explicit helper flag used to read it.

Validation: Prettier and git diff --check passed; command/flag instructions checked against the existing screenshot helper. Commit hooks passed TypeScript, C++ formatting and package preparation. Independent instruction review: no blockers. Verified at commit 50eec6863a674460ce1d0e572a17e58d33d77530.

This changes agent instructions and documentation on merge; no executable code changes. Mobile retesting and screenshots for this docs-only PR are not applicable under the existing exempt-path policy.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
react-native-quick-crypto Ready Ready Preview Oct 28, 2026 3:16pm UTC

Request Review

@boorad
boorad merged commit 27ca9a0 into main Oct 28, 2026
4 checks passed
@boorad boorad self-assigned this Oct 28, 2026
@boorad
boorad deleted the fix/pr-screenshot-evidence branch October 28, 2026 15:54

This branch was successfully deployed

1 active deployment
Preview — 50eec686 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant