You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HLSLExec] Make execution tests directly consumable by the HLK - #9104
Embed the HLK metadata that the DXCBuild conversion scripts used to inject, so ExecutionTest.cpp and ShaderOpArithTable.xml can be built into the HLK as-is. Under _HLK_CONF the test class is exposed as DxilConfTest to keep existing HLK waivers matching.
Embed the HLK metadata that the DXCBuild conversion scripts used to inject, so ExecutionTest.cpp and ShaderOpArithTable.xml can be built into the HLK as-is. Under _HLK_CONF the test class is exposed as DxilConfTest to keep existing HLK waivers matching.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The process-global verifier setup does not configure the runtime used by the selected Agility SDK factory, so /p:DriverVerifier=true can leave actual test devices unverified.
Makes HLSL execution tests directly consumable by the Windows Hardware Lab Kit (HLK), replacing metadata injection by DXCBuild conversion scripts while preserving waiver matching.
Changes:
Embeds HLK identifiers, descriptions, names, and specifications in test methods and XML rows.
Exposes the test class as DxilConfTest under _HLK_CONF.
Simplifies test dependencies and adds runtime-configurable driver verification.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The driver-verifier toggle targets the process-global runtime rather than the selected device-factory runtime, so verification can be reported as enabled without applying to the test devices.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The unguarded function leaves an unused Enabled parameter when _HLK_CONF is undefined, causing normal MSVC execution-test builds to fail because C4100 is treated as an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embed the HLK metadata that the DXCBuild conversion scripts used to inject, so ExecutionTest.cpp and ShaderOpArithTable.xml can be built into the HLK as-is. Under _HLK_CONF the test class is exposed as DxilConfTest to keep existing HLK waivers matching.