Repository navigation
Conversation
Bump the pinned pnpm to 12.21.0 and enable the experimental `lockfile.format: v13` (pnpm >= 12.19). It writes pnpm-lock.yaml with one entry per package version and one line per value, with trailing commas, so dependency updates touch fewer lines and concurrent PRs hit fewer lockfile merge conflicts. Resolved dependency versions are unchanged; only the pnpm binaries in the env lockfile and the lockfile layout change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VVaw7SDgegkh5P17SW6Ewa
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/effect
@orpc/evlog
@orpc/hibernation
@orpc/json-schema
@orpc/experimental-lock
@orpc/mcp
@orpc/msw
@orpc/nest
@orpc/next
@orpc/node
@orpc/openapi
@orpc/experimental-openapi-inference
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Important
Enabling the v13 lockfile format breaks Dependabot for this repo: dependabot-core's bundled pnpm parser cannot read lockfileVersion: 13.0 and dies with a TypeError on the first package entry. .github/dependabot.yml runs daily npm updates and every Dependabot PR rewrites pnpm-lock.yaml, so dependency and security updates stop until upstream supports the format.
Approach: the goal (fewer pnpm-lock.yaml merge conflicts) is reasonable and the "no resolved versions change" claim checks out exactly, but v13 is still experimental upstream and the tooling around this repo cannot read it yet — worth sequencing behind tooling support rather than merging it now.
Reviewed changes
package.json— the pnpm pin moves from12.16.1to12.21.0; nothing else in the repo references the old version.pnpm-workspace.yaml— addslockfile: { format: v13 }with an explanatory comment.pnpm-lock.yaml— rewritten into the two-document v13 layout (JSON with tabs and trailing commas,projectsinstead ofimporters, nosnapshots). I compared both lockfiles programmatically: same 2,303 package versions with identical specifiers and resolved versions across all 36 projects,pnpm install --frozen-lockfilereports the lockfile as up to date, andoxfmtleaves the file untouched.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
| # one line per value, with trailing commas, so a dependency update touches fewer | ||
| # lines and concurrent PRs hit fewer pnpm-lock.yaml merge conflicts. | ||
| lockfile: | ||
| format: v13 |
There was a problem hiding this comment.
Enabling v13 breaks Dependabot. dependabot-core's pnpm parser (@pnpm/lockfile-file@9.1.3) takes the legacy branch for a document with no snapshots, then reads pkgSnapshot.resolution, which v13 no longer writes — the helper dies with TypeError: Cannot use 'in' operator to search for 'tarball' in undefined on the very first package entry. Since .github/dependabot.yml updates npm deps daily and every Dependabot PR rewrites this lockfile, this silently ends dependency and security updates.
Technical details
# Dependabot cannot read the v13 lockfile
## Affected sites
- `pnpm-workspace.yaml:58` — `format: v13` opts into the experimental writer/reader.
- `.github/dependabot.yml` — daily `npm` updates; Dependabot PRs rewrite `pnpm-lock.yaml` (e.g. #2485).
- `pnpm-lock.yaml` — the project document is now `lockfileVersion: "13.0"`.
## Evidence
- `dependabot-core/npm_and_yarn/helpers/package.json` pins `@pnpm/lockfile-file@^9.1.3`; `lockfile-parser.ts` writes the last YAML document to a temp dir, calls `readWantedLockfile(dir, { ignoreIncompatible: true })`, then maps `lockfile.packages` and evaluates `"tarball" in pkgSnapshot.resolution`.
- Reproduced against this PR's lockfile: `readWantedLockfile` returns `{ lockfileVersion: '13.0', settings, projects, packages, importers: { '.': { specifiers: {} } } }`, and the first entry throws `TypeError: Cannot use 'in' operator to search for 'tarball' in undefined`. The Ruby wrapper turns that into `Dependabot::DependencyFileNotParseable`.
- Even with the crash fixed, `importers` collapsing to `{'.': {specifiers: {}}}` means every dependency loses its specifier and `dev` flag, so Dependabot would see all packages as production subdependencies with no requirements.
- pnpm's `lockfile.format` docs state v13 is experimental, "may change before pnpm 13 is released", and that pnpm versions without the setting cannot read it.
## Required outcome
- Dependency-update automation keeps working after this merges, or the format switch waits until it does.
## Suggested approach
- Land the 12.21.0 pin on its own and hold `lockfile.format: v13` until `dependabot-core` (and GitHub's dependency graph) can read `13.0`.
- If the switch is intentional now, document the expected Dependabot outage and confirm Dependabot alerts / the dependency graph still populate for the repo.
## Open questions for the human
- Does GitHub's dependency graph (which powers Dependabot alerts) accept `lockfileVersion: 13.0`? Worth checking on a throwaway branch before merge.|
Closing this for now because the v13 lockfile format is still experimental upstream. I'm keeping the branch so it can be reopened later. Blockers I confirmed before closing:
Worth revisiting once v13 is stable and Dependabot supports it. Generated by Claude Code |
Merging this PR will not alter performance1 warning
Comparing Footnotes
|

Summary
Bump the pinned pnpm from
12.16.1to12.21.0(latest), viapnpm self-update.Enable the v13 lockfile format in
pnpm-workspace.yaml:Why
The v13 format (added in pnpm 12.19) writes
pnpm-lock.yamlwith one entry per package version (no separatepackages/snapshotssections), one value per line, and a trailing comma after every entry. A dependency or peer update then changes only the lines that record its version, so concurrent PRs hit far fewer lockfile merge conflicts.Notes
name@versionsets of the old and new lockfiles: they match, apart from pnpm's own binaries in the env lockfile document.packageManager/devEnginespin makes pnpm switch to 12.21.0 automatically, and CI usespnpm/action-setup@v6, which reads that pin.Testing
pnpm install --frozen-lockfilesucceeds with pnpm 12.21.0pnpm run check(or this repo's equivalent) passesGenerated by Claude Code