Repository navigation
Conversation
Compare the full error message with the decoded status error before suppressing the status code prefix. Comparing only the underlying status loses context added by wrappers when the error is serialized again. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve error context added after decoding a gRPC status when the error is serialized again. The existing check compares only the underlying status, so it can discard wrapping that explains which operation failed. Compare the full error message as well, while retaining the status code and avoiding repeated status prefixes.
Found while investigating #7444. This fixes the loss of added context during serialization. Propagating the session-auth timeout cause remains a separate fix.