Repository navigation
Conversation
There was a problem hiding this comment.
I do understand the changes in line 30-31 and 42-43 of Electrical/PowerConverters/DCAC/Control/IntersectivePWM.mo
Unfortunately I cannot understand why the quantities and the units of the some variables have been changed, as this is a non backwards compatible change. Shouldn't there be a solution the same units ...
|
Thanks a lot for your thorough review @christiankral I have to admit I don't understand your remark "why the quantities and the units of the some variables have been changed". Regarding the changes amplitude=uMax -> 2 and offset=-uMax/2 -> -1: There is a new gain block diving the signal by uMax. Regarding the comparions SVPWM and IntersectivePWM: I have to dig into this. |
|
After enhancing the documentation including clarification of the voltages, I'll check and adapt:
Since it is not possible to separate PR #4840 from this one in order to resolve the issues addressed here properly, these rather limited changes in SVPWM done in #4840 (issue #4839) have been incorporated here. |
Obviously the regression testing will fail, as long as the reference files are not updated. This absolutely makes sense. You can download - potentially - new reference files from the report: |
|
@MatthiasBSchaefer I don't get it. |
|
@AHaumer Yes, the box you marked in the picture. New reference results were created based on the simulation, not based on the trajectory-comparison. Such, the box in the lower right corner of the Dymola-pattern is the place of new reference files. |
new reference results
|
Failure: Some checks of the regression testing failed. |
|
@MatthiasBSchaefer how do I see what failed?
I tried to follow your advice and committed new reference results (Modelica.Electrical.Machines.Examples.InductionMachines.IMC_InverterDrive and Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.ThreePhaseTwoLevel_PWM) to the PR itself (is this correct?). The whole procedure seems to be complicated and confusing. |
|
Failure: Some checks of the regression testing failed. |
|
Failure: Some checks of the regression testing failed. |
christiankral
left a comment
There was a problem hiding this comment.
I investigated Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.ThreePhaseTwoLevel_PWM, changing VNom from VNom=Vmax/sqrt(2) to half of this value: VNom=Vmax/sqrt(2)/2. Then I compared VNom with harmonic.y_rms for
- SVPWM
- Intersective
and found the following result:
The ratio of the two results is 115.3V / 100V = 1.153 =
|
@AHaumer I do understand, that there is a difference for |
|
I also compared MSL 4.1.0
PR #4812
|
@christiankral This is correct. Both PWM methods are in the linear mode without overmodulation. Just to show what happens if we just increase artificially the amplitude of the reference signal by 2/sqrt(3):
It is obvious that over-modulation leads to unwanted higher harmonic content. m is the modulation index w.r.t. theoretical maximum output voltage. |
@christiankral you are right. This is a bugfix, the handling of maximum voltage was wrong. Here's a comparison: MSL 4.1.0SVPWM PR4812SVPWM There are 3 bugfixes, and - you are rtíght - all of them have to be documented in the release notes:
Should I edit the release notes in this PR? |
|
Failure: Some checks of the regression testing failed. |
|
Failure: Some checks of the regression testing failed. |
|
Failure: Some checks of the regression testing failed. |
|
Failure: Some checks of the regression testing failed. |
Modelica.Blocks.Continuous.Filter is newly used in Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.ThreephaseTwoLevel_PWM. |
|
Failure: Some checks of the regression testing failed. |







Fixes the bugs adressed in #4089 and #4090 and refines the example for testing.