Repository navigation
MONGOID-6053 Respect the limit in HasMany::Enumerable#first and #last - #6208
Open
hfvmarques wants to merge 1 commit into
Open
hfvmarques wants to merge 1 commit into
hfvmarques wants to merge 1 commit into
Conversation
first(limit) and last(limit) on a has_many association returned a single document once the association was loaded, or when it had added documents, because the limit was only passed to the unloaded criteria. The same call returned an array of up to limit documents when the association was not loaded, so the result depended on whether something had loaded the association before. Handle a given limit separately: use the loaded documents when the association is loaded, or query only limit documents when it is not, then merge the added documents by _id, preferring the in-memory instance and keeping new documents last, as #each does. With a limit, both methods now always return an array. Calls without a limit are unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first(limit) and last(limit) on a has_many association returned a single document once the association was loaded, or when it had added documents, because the limit was only passed to the unloaded criteria. The same call returned an array of up to limit documents when the association was not loaded, so the result depended on whether something had loaded the association before.
Handle a given limit separately: use the loaded documents when the association is loaded, or query only limit documents when it is not, then merge the added documents by _id, preferring the in-memory instance and keeping new documents last, as #each does. With a limit, both methods now always return an array. Calls without a limit are unchanged.
MONGOID-6053
Please backport it to 9.0-stable