Skip to content

Add description to arista_eos_show_ipv6_bgp_sum - #2367

Open
alex4lbin wants to merge 3 commits into
networktocode:masterfrom
alex4lbin:fix_arista_eos_show_ipv6_bgp_summary
Open

Add description to arista_eos_show_ipv6_bgp_sum#2367
alex4lbin wants to merge 3 commits into
networktocode:masterfrom
alex4lbin:fix_arista_eos_show_ipv6_bgp_summary

Conversation

@alex4lbin

@alex4lbin alex4lbin commented Sep 22, 2026

Copy link
Copy Markdown

Problem

Parsing failed for Arista EOS show ipv6 bgp summary output when the header included an unexpected Description field.

Solution

  • added support for the Description field to arista_eos_show_ipv6_bgp_summary.textfsm
  • added raw output containing Description field and the corresponding .yaml file
  • updated existing .yaml files to account for the newly added field

Testing

  • ran invoke tests locally and all tests passed

claude[bot]
claude Bot reviewed Sep 22, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mjbear mjbear changed the title arista_eos: add description field support to show_ipv6_bgp_summary template Add description to arista_eos_show_ipv6_bgp_sum Sep 23, 2026
@mjbear
Regenerate test data keys in alphabetical order
b848cca
@mjbear
Simplify description regex and reorder
561e489 
- Remove zero or more regex from description since if there
   is no description, the pattern matches an existing line
   pattern
- Reorder rules so the longer match is closer to the top
@mjbear

mjbear commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @alex4lbin
Thank you for your PR.

There are a couple of updates I'd like to make as a maintainer. It seems like this PR currently may not allow maintainer edits. Could you check that setting?

@alex4lbin

alex4lbin commented Sep 23, 2026

Copy link
Copy Markdown
Author

Hi @mjbear
Looks like I accidentally disabled it. Should be fixed now.

@mjbear mjbear removed the question label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner
@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner
@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner
@mjbear mjbear Awaiting requested review from mjbear mjbear is a code owner
@matt852 matt852 Awaiting requested review from matt852 matt852 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex4lbin @mjbear