Repository navigation
drivers/upsdrvctl.c: send_all_drivers(): restart the list for each sdorder - #3835
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
…order The list pointer was never reset, so only devices with the first sdorder were shut down. Closes: networkupstools#3793 Signed-off-by: Jay Hemnani <193022578+jayhemnani9910@users.noreply.github.com>
|
Preparing a ZIP file with standard source tarball and another tarball with pre-built docs for commit 9176bab ... |
|
❌ Build nut 2.8.5.5975-master failed (commit c52de81f9b by @jayhemnani9910) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3793
upsdrvctl shutdownwith no device name only shut down devices with the firstsdorder. The list pointer was set once before thesdorderloop, reached the end on the first pass, and later passes had nothing to walk. On a multi-UPS setup the later units never got the shutdown command.The pointer now restarts for each
sdorder. With three devices atsdorder0, 1 and 2,upsdrvctl -t -D -D shutdownprinted oneexec:line before and prints all three in order now.Tested with
upsdrvctl -t, no real UPS. I built onlycommonanddrivers/upsdrvctl, so the full test suite didn't run. This code has no unit test.Assisted by Claude Code.