Skip to content

[stable35] fix: improve gap cursor usage - #9554

Merged
mejo- merged 2 commits into
stable35from
backport/9552/stable35
Nov 5, 2026
Merged

mejo- merged 2 commits into
stable35from
backport/9552/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 5, 2026

Copy link
Copy Markdown

Backport of PR #9552

Make sure the gap cursor is visible in dark mode and fix its padding so
the content doesn't jump when gap cursor is displayed.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@backportbot
backportbot Bot requested a review from benjaminfrueh November 5, 2026 12:10
@backportbot backportbot Bot added bug Something isn't working 3. to review ux AI assisted This PR contains AI-assisted commits labels Nov 5, 2026
@backportbot backportbot Bot added this to the Nextcloud 35.0.3 milestone Nov 5, 2026
@mejo-
mejo- enabled auto-merge November 5, 2026 12:10
The gap cursor plugin accepts a position only if the parent's content
match at that index has a textblock as its default type. A we set
`block+ comments? footnotes?` as content for the Document node, the
content match after first block lists footnotes first. Therefore we have
to explicitely allow gapcursor for the Documents node.

Also leave a gap before tables for the gap cursor so it's possible to
navigate the cursor between two tables with the mouse.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the backport/9552/stable35 branch from b2d6243 to f498b80 Compare November 5, 2026 13:08
@mejo-
mejo- disabled auto-merge November 5, 2026 14:22
@mejo-
mejo- merged commit 7fe4399 into stable35 Nov 5, 2026
62 of 64 checks passed
@mejo-
mejo- deleted the backport/9552/stable35 branch November 5, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits bug Something isn't working ux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant