Skip to content

Adding Continuous Acquisition Multiple Sample External Trigger example in NI-DMM - #2229

Merged
vnktshr21 merged 12 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-cont-acq-multiple-samples-ext-trig
Nov 3, 2026
Merged

vnktshr21 merged 12 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-cont-acq-multiple-samples-ext-trig

Conversation

@NI-velmurugan

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR adds nidmm_cont_acq_multiple_samples_ext_trig.py, a Python adaptation of the LabVIEW Cont Acq Multiple Samples - Ext Trig - Ext SampleTrig.vi

What testing has been done?

Manually tested the example using simulated hardware and the real hardware

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

@divakar-selvam07 this PR ready for your review.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (c04a78e) to head (279c408).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2229   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22830    22830           
=======================================
+ Hits        20118    20119    +1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.37% <ø> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NI-velmurugan NI-velmurugan changed the title Users/velmurugan/add nidmm cont acq multiple samples ext trig Adding Continuous Acquisition Multiple Sample External Trigger example in NI-DMM Oct 21, 2026
@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

@jarnoldNI, the PR is ready for your review.

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

Removed the plotting as per Marcos's suggestion on #2220

@NI-velmurugan
NI-velmurugan marked this pull request as ready for review November 3, 2026 05:51
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@vnktshr21
vnktshr21 merged commit 9b70885 into ni:master Nov 3, 2026
55 of 58 checks passed
@divakar-selvam07
divakar-selvam07 deleted the users/velmurugan/add-nidmm-cont-acq-multiple-samples-ext-trig branch November 3, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants