Repository navigation
Honor InvalidRepeatedCapabilityError extra error metadata in converters.py - #2244
mohit-emerson wants to merge 3 commits into
Conversation
…or is not generated Drivers that have repeated capabilities but do not list InvalidRepeatedCapabilityError in extra_errors_used now pass repeated capability strings they cannot parse to the driver as-is, and the driver reports if they are invalid. Only a simple two-part range is expanded, and unsupported types raise TypeError. Drivers that list the error generate the same code as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 88 88
Lines 22830 22830
=======================================
+ Hits 20118 20119 +1
+ Misses 2712 2711 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
None of the APIs currently do this, so it feels like if it happens in the future, it may be a mistake in the metadata and we may want to assert to prevent it. |
We should either not have that option itself or have the option and ensure it's used consistently across all codegen. I believe this PR was just ensuring that consistency. Why would we want have an option in metadata which will be asserted to be specified always? @mohit-emerson , was there any driver which was not specifying this metadata field? |
Only |
[] I've updated CHANGELOG.md if applicable.[] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
InvalidRepeatedCapabilityErroris not generated.Drivers that have repeated capabilities but do not list
InvalidRepeatedCapabilityErrorinextra_errors_usednow pass repeated capability strings they cannot parse to the driver as-is, and the driver reports if they are invalid. Only a simple two-part range is expanded, and unsupported types raise TypeError. Drivers that list the error generate the same code as before.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Validations