Skip to content

Cap the version of pytest that we use - #2252

Merged
marcoskirsch merged 1 commit into
ni:masterfrom
ni-jfitzger:cap-pytest-version
Oct 30, 2026
Merged

marcoskirsch merged 1 commit into
ni:masterfrom
ni-jfitzger:cap-pytest-version

Conversation

@ni-jfitzger

Copy link
Copy Markdown
Collaborator
  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Cap the pytest version used under 9.2.0, for all use cases.
pytest 9.2.0 recently released with pytest-dev/pytest#15295.

This broke our system tests.
Unit tests were unaffected, but we really shouldn't be blindly pulling in the latest version of deps, so I'm capping it everywhere.

We ought to do this for our other deps, as well, and setup Renovate, but I'm keeping this PR focused to fixing the current testing issue.

List issues fixed by this Pull Request below, if any.

What testing has been done?

PR Checks

@codecov-commenter

codecov-commenter commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (609c4ee) to head (ad5f652).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2252   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22830    22830           
=======================================
+ Hits        20118    20119    +1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.37% <ø> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcoskirsch
marcoskirsch merged commit 89108d2 into ni:master Oct 30, 2026
49 checks passed
@ni-jfitzger
ni-jfitzger deleted the cap-pytest-version branch October 30, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System testing is broken with a pytest cache error

3 participants