Repository navigation
Keep the find field's room for the count on the count's side - #14
Merged
Merged
Conversation
In a right-to-left window the count's anchor is mirrored to the left edge, but padding isn't, so long search text ran under it. Reserve the room on whichever side the count is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 [Low impact] This PR appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "Keep the find field's room for the count..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Arabic, Hebrew, Persian and Urdu the window is mirrored, which moves the match count in the find field to the left edge. The field's padding isn't mirrored, so the room for the count stayed on the right and long search text ran underneath it. Now the room is reserved on whichever side the count is on.
Follows up Greptile's review of #11.
🤖 Generated with Claude Code