Repository navigation
[FSSDK-13402] Replace rollup with rolldown - #1172
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
coverage: 77.513%. remained the same — raju/rolldown into master |
Raju Ahmed (raju-opti)
force-pushed
the
raju/rolldown
branch
from
November 4, 2026 14:47
90250cc to
bf0ba5f
Compare
Raju Ahmed (raju-opti)
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
The standalone UMD build can fail without generated message modules, and the CJS example runner can test and delete a stale SDK archive while leaving the current version untested.
2 open issues
What changed in this PR
Migrates the SDK’s multi-platform bundling from Rollup to Rolldown and separates build-time requirements from Node 18 runtime validation.
Changes:
- Replaces Rollup plugins with Rolldown’s built-in resolution and minification, with explicit syntax and platform settings.
- Moves automatic builds from
preparetoprepackand adds tarball reuse to the CommonJS example runner. - Updates CI to build on Node 20 and test the packaged CommonJS SDK on Node 18.
| File | Description |
|---|---|
scripts/run-cjs-example.js |
Adds --skip-build support using an existing SDK tarball. |
rolldown.config.mjs |
Migrates bundle configuration, platform resolution, and minification to Rolldown. |
package.json |
Updates build commands, lifecycle hooks, and development dependencies. |
package-lock.json |
Records Rolldown dependencies and removes obsolete packages. |
lib/import.react_native/README.md |
Updates shim documentation for Rolldown and its CommonJS interop. |
.github/workflows/javascript.yml |
Separates Node 20 packaging from Node 18 runtime testing. |
Review effort: Balanced
Md Junaed Hossain (junaed-optimizely)
approved these changes
Nov 5, 2026
Md Junaed Hossain (junaed-optimizely)
left a comment
Md Junaed Hossain (junaed-optimizely)
left a comment
Contributor
There was a problem hiding this comment.
I think the first comment from copilot is worth giving a look. LGTM othewise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollupwithrolldownwhich has functionalities of most of the rollup plugins we use built-in, and much faster bundling time.Issues